Improvements for AWS/ECS attributes #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `aws.ecs.task.id`, to reflect changes introduced by [#29062][pr] Also, fixed description for `aws.ecs.task.arn`, as it does not reflect TaskDefinition ARN (as was incorrectly stated), but the ARN of the running ECS Task. [pr]: open-telemetry/opentelemetry-collector-contrib#29602
mx-psi
reviewed
Dec 11, 2023
mx-psi
approved these changes
Dec 11, 2023
bryan-aguilar
approved these changes
Dec 11, 2023
jsuereth
reviewed
Dec 15, 2023
joaopgrassi
reviewed
Jan 10, 2024
`task.id` is extracted from `task.arn`, so it's conditionally required based on its presence.
joaopgrassi
approved these changes
Jan 10, 2024
jsuereth
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
aws.ecs.task.id, to reflect changes introduced by #29062.Also, fixed description for
aws.ecs.task.arn, as it does not reflect TaskDefinition ARN (as was incorrectly stated), but the ARN of the running ECS Task.Fixes open-telemetry/opentelemetry-collector-contrib#8274
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist